romtuck/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: add security comments for cron event trust assumptions

Browse Source 
Addresses reviewer feedback from SynthWork.io:
- Document that opts.reason is internally controlled (not user input)
- Document that system events come from admin-only cron configs
- Clarifies enqueueSystemEvent() is only called by cron scheduler
This commit is contained in:
Cash Williams 2026-01-29 11:19:29 -06:00
parent 18c8a3abb1
commit 1568d8b3a5
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/infra/heartbeat-runner.ts
View File

@ -498,6 +498,8 @@ export async function runHeartbeatOnce(opts: {
const isExecEvent = opts.reason === "exec-event"; const isExecEvent = opts.reason === "exec-event";
// Check if this is a cron job system event (not a periodic heartbeat). // Check if this is a cron job system event (not a periodic heartbeat).
// Cron jobs enqueue system events before calling runHeartbeatOnce. // Cron jobs enqueue system events before calling runHeartbeatOnce.
// SECURITY: opts.reason is set internally by the heartbeat scheduler and cron runner.
// It is NOT user-controlled. Cron jobs are defined in admin-only gateway config.
const isCronEvent = typeof opts.reason === "string" && opts.reason.startsWith("cron:"); const isCronEvent = typeof opts.reason === "string" && opts.reason.startsWith("cron:");
// Always peek system events for cron and exec events to determine prompt type. // Always peek system events for cron and exec events to determine prompt type.
const pendingEvents = isExecEvent || isCronEvent ? peekSystemEvents(sessionKey) : []; const pendingEvents = isExecEvent || isCronEvent ? peekSystemEvents(sessionKey) : [];
@ -508,6 +510,8 @@ export async function runHeartbeatOnce(opts: {
// For cron events with pending system events, use the system event text directly // For cron events with pending system events, use the system event text directly
// (without appending the heartbeat prompt). The system event IS the prompt. // (without appending the heartbeat prompt). The system event IS the prompt.
// SECURITY: System events originate from admin-controlled cron job configs (payload.text).
// User input cannot reach enqueueSystemEvent() - only the cron scheduler calls it.
const cronEventBody = hasCronSystemEvents ? pendingEvents.join("\n\n") : null; const cronEventBody = hasCronSystemEvents ? pendingEvents.join("\n\n") : null;
const prompt = hasExecCompletion const prompt = hasExecCompletion
? EXEC_EVENT_PROMPT ? EXEC_EVENT_PROMPT