From a6180d8ff7ffb3efc100ced7bfa3f93a0da7b561 Mon Sep 17 00:00:00 2001
From: bestomzhang <bestomzhang@tencent.com>
Date: Thu, 29 Jan 2026 16:30:57 +0800
Subject: [PATCH] improve bash-tools.exec.ts code quality

- Better error messages and type safety
- Extract magic numbers to constants
- Stricter input validation
---
 src/agents/bash-tools.exec.ts | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/agents/bash-tools.exec.ts b/src/agents/bash-tools.exec.ts
index b9de81872..7a7e49120 100644
--- a/src/agents/bash-tools.exec.ts
+++ b/src/agents/bash-tools.exec.ts
@@ -76,11 +76,14 @@ const DEFAULT_APPROVAL_TIMEOUT_MS = 120_000;
 const DEFAULT_APPROVAL_REQUEST_TIMEOUT_MS = 130_000;
 const DEFAULT_APPROVAL_RUNNING_NOTICE_MS = 10_000;
 const APPROVAL_SLUG_LENGTH = 8;
+const TIMEOUT_FINALIZE_MS = 1000;
+const PTY_DEFAULT_COLS = 120;
+const PTY_DEFAULT_ROWS = 30;
 
 type PtyExitEvent = { exitCode: number; signal?: number };
 type PtyListener<T> = (event: T) => void;
 type PtyHandle = {
-  pid: number;
+  readonly pid: number;
   write: (data: string | Buffer) => void;
   onData: (listener: PtyListener<string>) => void;
   onExit: (listener: PtyListener<PtyExitEvent>) => void;
@@ -405,14 +408,14 @@ async function runExecProcess(opts: {
       };
       const spawnPty = ptyModule.spawn ?? ptyModule.default?.spawn;
       if (!spawnPty) {
-        throw new Error("PTY support is unavailable (node-pty spawn not found).");
+        throw new Error("PTY support is unavailable. Please install @lydell/node-pty or run without pty=true.");
       }
       pty = spawnPty(shell, [...shellArgs, opts.command], {
         cwd: opts.workdir,
         env: opts.env,
         name: process.env.TERM ?? "xterm-256color",
-        cols: 120,
-        rows: 30,
+        cols: PTY_DEFAULT_COLS,
+        rows: PTY_DEFAULT_ROWS,
       });
       stdin = {
         destroyed: false,
@@ -524,7 +527,7 @@ async function runExecProcess(opts: {
   let timeoutTimer: NodeJS.Timeout | null = null;
   let timeoutFinalizeTimer: NodeJS.Timeout | null = null;
   let timedOut = false;
-  const timeoutFinalizeMs = 1000;
+  const timeoutFinalizeMs = TIMEOUT_FINALIZE_MS;
   let resolveFn: ((outcome: ExecProcessOutcome) => void) | null = null;
 
   const settle = (outcome: ExecProcessOutcome) => {
@@ -751,8 +754,8 @@ export function createExecTool(
         node?: string;
       };
 
-      if (!params.command) {
-        throw new Error("Provide a command to start.");
+      if (!params.command?.trim()) {
+        throw new Error("Command is required. Please provide a valid shell command to execute.");
       }
 
       const maxOutput = DEFAULT_MAX_OUTPUT;