From 56096d81eeb4c37b9e83f3681dd07ecdb9037669 Mon Sep 17 00:00:00 2001
From: Pranav Katariya <pranavk@live.in>
Date: Tue, 27 Jan 2026 18:53:27 -0800
Subject: [PATCH] fix: handle undefined values in Zoom onboarding prompts

- Wrap prompter.text() results with String() and trim()
- Fixes TypeError when accessing .includes() on undefined
- Ensures all input values are properly converted to strings

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
---
 src/channels/plugins/onboarding/zoom.ts | 65 ++++++++++++++++---------
 1 file changed, 42 insertions(+), 23 deletions(-)

diff --git a/src/channels/plugins/onboarding/zoom.ts b/src/channels/plugins/onboarding/zoom.ts
index a4965e973..6b30f0c36 100644
--- a/src/channels/plugins/onboarding/zoom.ts
+++ b/src/channels/plugins/onboarding/zoom.ts
@@ -82,32 +82,51 @@ export const zoomOnboardingAdapter: ChannelOnboardingAdapter = {
 
     await noteZoomHelp(prompter);
 
-    const clientId = await prompter.text({
-      message: "Zoom Client ID",
-      placeholder: "lfcOyplW...",
-      validate: (value) => (value?.trim() ? undefined : "Client ID is required"),
-    });
+    const clientId = String(
+      await prompter.text({
+        message: "Zoom Client ID",
+        placeholder: "lfcOyplW...",
+        validate: (value) => {
+          const trimmed = String(value ?? "").trim();
+          return trimmed ? undefined : "Client ID is required";
+        },
+      }),
+    ).trim();
 
-    const clientSecret = await prompter.text({
-      message: "Zoom Client Secret",
-      placeholder: "rm48DW7m...",
-      validate: (value) => (value?.trim() ? undefined : "Client Secret is required"),
-    });
+    const clientSecret = String(
+      await prompter.text({
+        message: "Zoom Client Secret",
+        placeholder: "rm48DW7m...",
+        validate: (value) => {
+          const trimmed = String(value ?? "").trim();
+          return trimmed ? undefined : "Client Secret is required";
+        },
+      }),
+    ).trim();
 
-    const botJid = await prompter.text({
-      message: "Zoom Bot JID",
-      placeholder: "bot@xmpp.zoom.us",
-      validate: (value) =>
-        value?.includes("@xmpp")
-          ? undefined
-          : "Bot JID should contain @xmpp.zoom.us or @xmppdev.zoom.us",
-    });
+    const botJid = String(
+      await prompter.text({
+        message: "Zoom Bot JID",
+        placeholder: "bot@xmpp.zoom.us",
+        validate: (value) => {
+          const str = String(value ?? "").trim();
+          return str.includes("@xmpp")
+            ? undefined
+            : "Bot JID should contain @xmpp.zoom.us or @xmppdev.zoom.us";
+        },
+      }),
+    ).trim();
 
-    const secretToken = await prompter.text({
-      message: "Zoom Secret Token",
-      placeholder: "kVJhHKxo...",
-      validate: (value) => (value?.trim() ? undefined : "Secret Token is required"),
-    });
+    const secretToken = String(
+      await prompter.text({
+        message: "Zoom Secret Token",
+        placeholder: "kVJhHKxo...",
+        validate: (value) => {
+          const trimmed = String(value ?? "").trim();
+          return trimmed ? undefined : "Secret Token is required";
+        },
+      }),
+    ).trim();
 
     // Determine environment from Bot JID
     const isDev = botJid.includes("@xmppdev");