romtuck/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(cron): make cron.list/status non-blocking when store is loaded

Browse Source
This commit is contained in:
Josh Wegener 2026-01-30 06:45:23 -07:00
parent da71eaebd2
commit 572006f9e1
1 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/cron/service/ops.ts
View File

@ -39,6 +39,18 @@ export function stop(state: CronServiceState) {
}
export async function status(state: CronServiceState) {
// Fast path: if the store is already loaded, avoid waiting behind long-running
// cron executions that may hold the cron lock (e.g., isolated agent jobs).
// This keeps `cron.status` responsive.
if (state.store) {
return {
enabled: state.deps.cronEnabled,
storePath: state.deps.storePath,
jobs: state.store.jobs.length ?? 0,
nextWakeAtMs: state.deps.cronEnabled === true ? (nextWakeAtMs(state) ?? null) : null,
};
}
return await locked(state, async () => {
await ensureLoaded(state);
return {
@ -51,9 +63,18 @@ export async function status(state: CronServiceState) {
}
export async function list(state: CronServiceState, opts?: { includeDisabled?: boolean }) {
const includeDisabled = opts?.includeDisabled === true;
// Fast path: if the store is already loaded, avoid waiting behind long-running
// cron executions that may hold the cron lock (e.g., isolated agent jobs).
// This keeps `cron.list` responsive.
if (state.store) {
const jobs = state.store.jobs.filter((j) => includeDisabled || j.enabled);
return jobs.slice().sort((a, b) => (a.state.nextRunAtMs ?? 0) - (b.state.nextRunAtMs ?? 0));
}
return await locked(state, async () => {
await ensureLoaded(state);
const includeDisabled = opts?.includeDisabled === true;
const jobs = (state.store?.jobs ?? []).filter((j) => includeDisabled || j.enabled);
return jobs.sort((a, b) => (a.state.nextRunAtMs ?? 0) - (b.state.nextRunAtMs ?? 0));
});