Merge 3105a46867 into 4583f88626

CHANGELOG.md

@@ -14,6 +14,7 @@ Status: beta.
 - Memory Search: allow extra paths for memory indexing. (#3600) Thanks @kira-ariaki.
 
 ### Changes
+- Gateway: prevent crash on transient fetch/network failures (#3815)
 - Providers: add Venice AI integration; update Moonshot Kimi references to kimi-k2.5; update MiniMax API endpoint/format. (#2762, #3064)
 - Providers: add Xiaomi MiMo (mimo-v2-flash) support and onboarding flow. (#3454) Thanks @WqyJh.
 - Telegram: quote replies, edit-message action, silent sends, sticker support + vision caching, linkPreview toggle, plugin sendPayload support. (#2900, #2394, #2382, #2548, #1700, #1917)

src/macos/gateway-daemon.test.ts

@@ -0,0 +1,59 @@
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+import process from "node:process";
+
+describe("gateway-daemon unhandled rejection handler", () => {
+  let exitCalls: Array<string | number | null> = [];
+  let consoleErrorSpy: ReturnType<typeof vi.spyOn>;
+  let consoleWarnSpy: ReturnType<typeof vi.spyOn>;
+
+  beforeEach(async () => {
+    exitCalls = [];
+
+    vi.spyOn(process, "exit").mockImplementation((code: string | number | null | undefined) => {
+      if (code !== undefined && code !== null) {
+        exitCalls.push(code);
+      }
+    });
+
+    consoleErrorSpy = vi.spyOn(console, "error").mockImplementation(() => {});
+    consoleWarnSpy = vi.spyOn(console, "warn").mockImplementation(() => {});
+
+    // Install the handler (same import the daemon uses)
+    const { installUnhandledRejectionHandler } = await import(
+      "../infra/unhandled-rejections.js"
+    );
+    installUnhandledRejectionHandler();
+  });
+
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  it("does NOT exit on transient fetch failures (ECONNRESET)", () => {
+    const fetchErr = Object.assign(new TypeError("fetch failed"), {
+      cause: { code: "ECONNRESET" },
+    });
+
+    process.emit("unhandledRejection", fetchErr, Promise.resolve());
+
+    expect(exitCalls).toEqual([]);
+    expect(consoleWarnSpy).toHaveBeenCalledWith(
+      "[moltbot] Non-fatal unhandled rejection (continuing):",
+      expect.stringContaining("fetch failed"),
+    );
+  });
+
+  it("exits on fatal errors like OOM", () => {
+    const oomErr = Object.assign(new Error("Out of memory"), {
+      code: "ERR_OUT_OF_MEMORY",
+    });
+
+    process.emit("unhandledRejection", oomErr, Promise.resolve());
+
+    expect(exitCalls).toEqual([1]);
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      "[moltbot] FATAL unhandled rejection:",
+      expect.stringContaining("Out of memory"),
+    );
+  });
+});

src/macos/gateway-daemon.ts

@@ -41,6 +41,10 @@ async function main() {
     (globalThis as unknown as { Long?: unknown }).Long = Long;
   }
 
+  // Prevent crashes on transient fetch/network failures (#3815)
+  const { installUnhandledRejectionHandler } = await import("../infra/unhandled-rejections.js");
+  installUnhandledRejectionHandler();
+
   const [
     { loadConfig },
     { startGatewayServer },