From 61136871eb810ce2f00fc74da68484f6fa356e8f Mon Sep 17 00:00:00 2001 From: TideFinder <68721273+papago2355@users.noreply.github.com> Date: Tue, 27 Jan 2026 13:34:52 +0900 Subject: [PATCH] =?UTF-8?q?Fix=20a=20subtle=20bug:=20`modelDefault`=20does?= =?UTF-8?q?n=E2=80=99t=20apply=20when=20provider=20=3D=3D=3D=20"auto"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) --- src/agents/memory-search.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/agents/memory-search.ts b/src/agents/memory-search.ts index c89bad422..9b086ee91 100644 --- a/src/agents/memory-search.ts +++ b/src/agents/memory-search.ts @@ -121,7 +121,9 @@ function mergeConfig( const overrideRemote = overrides?.remote; const hasRemote = Boolean(defaultRemote || overrideRemote); const includeRemote = - hasRemote || provider === "openai" || provider === "gemini" || provider === "auto"; + Boolean(overrideRemote?.baseUrl || overrideRemote?.apiKey || overrideRemote?.headers || + defaultRemote?.baseUrl || defaultRemote?.apiKey || defaultRemote?.headers) || + provider === "openai" || provider === "gemini" || provider === "auto"; const batch = { enabled: overrideRemote?.batch?.enabled ?? defaultRemote?.batch?.enabled ?? true, wait: overrideRemote?.batch?.wait ?? defaultRemote?.batch?.wait ?? true, @@ -146,7 +148,7 @@ function mergeConfig( const modelDefault = provider === "gemini" ? DEFAULT_GEMINI_MODEL - : provider === "openai" + : provider === "openai" || provider === "auto" ? DEFAULT_OPENAI_MODEL : undefined; const model = overrides?.model ?? defaults?.model ?? modelDefault ?? "";