From 972af57d30daf4247667b672392170d741721962 Mon Sep 17 00:00:00 2001
From: SpencersServer <spennyserver@SpencerrversAir.home>
Date: Thu, 29 Jan 2026 13:24:06 +0200
Subject: [PATCH] security: add tool policy validation and privilege tracking

- Add SENSITIVE_TOOLS and HIGH_PRIVILEGE_TOOLS sets
  to identify tools requiring careful consideration

- Add validateToolPolicy() function that checks for:
  - Wildcard allow entries (grants all tools)
  - High-privilege tools in allow list
  - Broad allow lists without explicit deny lists

- Add toolRequiresElevation() to check if a tool
  needs elevated permissions in current context

- Returns typed warnings with severity levels
---
 src/agents/tool-policy.ts | 104 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 104 insertions(+)

diff --git a/src/agents/tool-policy.ts b/src/agents/tool-policy.ts
index 514b5338a..5eb36f596 100644
--- a/src/agents/tool-policy.ts
+++ b/src/agents/tool-policy.ts
@@ -232,3 +232,107 @@ export function resolveToolProfilePolicy(profile?: string): ToolProfilePolicy |
     deny: resolved.deny ? [...resolved.deny] : undefined,
   };
 }
+
+/**
+ * SECURITY: Sensitive tools that should require explicit opt-in
+ * or elevated permissions when used from certain contexts.
+ */
+export const SENSITIVE_TOOLS = new Set([
+  "exec",
+  "process",
+  "gateway",
+  "message",
+  "nodes",
+]);
+
+/**
+ * SECURITY: High-privilege tools that should be carefully considered.
+ */
+export const HIGH_PRIVILEGE_TOOLS = new Set([
+  "gateway", // Can restart, update, modify config
+  "exec", // Can run arbitrary commands
+  "process", // Can manage background processes
+  "nodes", // Can interact with paired devices
+]);
+
+export type PolicyValidationWarning = {
+  code: string;
+  message: string;
+  severity: "info" | "warn" | "critical";
+};
+
+/**
+ * SECURITY: Validate a tool policy for potential security issues.
+ * Returns warnings about dangerous configurations.
+ */
+export function validateToolPolicy(policy: ToolPolicyLike | undefined): PolicyValidationWarning[] {
+  const warnings: PolicyValidationWarning[] = [];
+
+  if (!policy) return warnings;
+
+  // Check for wildcards in allow list
+  if (policy.allow) {
+    const hasWildcard = policy.allow.some(
+      (entry) => entry === "*" || entry === "all" || entry === "group:all"
+    );
+    if (hasWildcard) {
+      warnings.push({
+        code: "policy.wildcard_allow",
+        message:
+          "Policy contains wildcard allow entry. This grants access to all tools, including sensitive ones.",
+        severity: "warn",
+      });
+    }
+
+    // Check if high-privilege tools are explicitly allowed without corresponding deny
+    const expanded = expandToolGroups(policy.allow);
+    const deniedSet = new Set(expandToolGroups(policy.deny));
+
+    for (const tool of HIGH_PRIVILEGE_TOOLS) {
+      if (expanded.includes(tool) && !deniedSet.has(tool)) {
+        warnings.push({
+          code: `policy.high_privilege.${tool}`,
+          message: `High-privilege tool '${tool}' is allowed. Ensure this is intentional.`,
+          severity: "info",
+        });
+      }
+    }
+  }
+
+  // Check for empty deny list when allow is broad
+  if (policy.allow && (!policy.deny || policy.deny.length === 0)) {
+    const expanded = expandToolGroups(policy.allow);
+    if (expanded.length > 10) {
+      warnings.push({
+        code: "policy.broad_allow_no_deny",
+        message:
+          "Broad allow list with no explicit deny list. Consider denying sensitive tools explicitly.",
+        severity: "info",
+      });
+    }
+  }
+
+  return warnings;
+}
+
+/**
+ * SECURITY: Check if a tool requires elevated permissions for the current context.
+ */
+export function toolRequiresElevation(
+  toolName: string,
+  context: { sandboxed?: boolean; channel?: string }
+): boolean {
+  const normalized = normalizeToolName(toolName);
+
+  // In sandbox mode, exec on gateway host requires elevation
+  if (context.sandboxed && normalized === "exec") {
+    return true;
+  }
+
+  // Gateway tool always requires careful consideration
+  if (normalized === "gateway") {
+    return true;
+  }
+
+  return false;
+}