From c13011e2d0e66228a9a1fe5b61a01f7941e83a52 Mon Sep 17 00:00:00 2001 From: 1alyx Date: Thu, 29 Jan 2026 23:05:15 -0500 Subject: [PATCH] add newline fix task --- NEWLINE-FIX-TASK.md | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 NEWLINE-FIX-TASK.md diff --git a/NEWLINE-FIX-TASK.md b/NEWLINE-FIX-TASK.md new file mode 100644 index 000000000..2a8860c4f --- /dev/null +++ b/NEWLINE-FIX-TASK.md @@ -0,0 +1,45 @@ +# Task: Fix Leading Newline Bug + +## Problem +iMessage responses have 1-2 blank lines prepended. Root cause: Anthropic models in thinking mode emit a `\n\n` text block before the thinking block, and the streaming/flush path doesn't trim leading whitespace. + +## Fixes Required (apply ALL THREE for defense in depth) + +### Fix 1: `emitBlockChunk` in `src/agents/pi-embedded-subscribe.ts` +Find the line that does `.trimEnd()` on the chunk text and change it to `.trim()`: +``` +// Find something like: +const chunk = stripBlockTags(text, state.blockState).trimEnd(); +// Change to: +const chunk = stripBlockTags(text, state.blockState).trim(); +``` + +### Fix 2: `collapseConsecutiveDuplicateBlocks` in `src/agents/pi-embedded-helpers/errors.ts` +Fix the early return to use trimmed text instead of original: +``` +// Find: +if (blocks.length < 2) return text; +// Change to: +if (blocks.length < 2) return trimmed; +``` + +### Fix 3: Safety net in `sanitizeUserFacingText` in same file (`errors.ts`) +Make sure the final return trims: +``` +// Find the final return of collapseConsecutiveDuplicateBlocks(stripped) +// Change to: +return collapseConsecutiveDuplicateBlocks(stripped).trim(); +``` + +## Rules +- Edit the TypeScript SOURCE files in `src/`, NOT the compiled `dist/` files +- Build after changes: `npm run build` or `npx tsc` +- Commit with message: `fix: trim leading newlines from streaming/block-flush text output` +- Co-author: `Co-authored-by: Zach Canepa ` +- Push to branch: `fix/leading-newline-trim` +- Do NOT create a PR, just push + +## Verification +After building, check that the compiled JS in `dist/` reflects your changes: +- `dist/agents/pi-embedded-subscribe.js` should have `.trim()` not `.trimEnd()` +- `dist/agents/pi-embedded-helpers/errors.js` should return `trimmed` not `text` in early return