From c2486e6806830b8d80a3a8243ed13024d7504738 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EB=B3=80=EC=9E=AC=EC=A7=84?= Date: Fri, 30 Jan 2026 16:56:09 +0900 Subject: [PATCH] refactor: cleanup dead code and standardize logging --- extensions/diagnostics-otel/src/service.test.ts | 5 +---- src/agents/skills/workspace.ts | 6 ++++-- src/hooks/bundled/session-memory/handler.ts | 17 ----------------- 3 files changed, 5 insertions(+), 23 deletions(-) diff --git a/extensions/diagnostics-otel/src/service.test.ts b/extensions/diagnostics-otel/src/service.test.ts index be5ea6f0c..b20905667 100644 --- a/extensions/diagnostics-otel/src/service.test.ts +++ b/extensions/diagnostics-otel/src/service.test.ts @@ -83,10 +83,7 @@ vi.mock("@opentelemetry/sdk-trace-base", () => ({ })); vi.mock("@opentelemetry/resources", () => ({ - Resource: class { - // eslint-disable-next-line @typescript-eslint/no-useless-constructor - constructor(_value?: unknown) {} - }, + Resource: class {}, })); vi.mock("@opentelemetry/semantic-conventions", () => ({ diff --git a/src/agents/skills/workspace.ts b/src/agents/skills/workspace.ts index 7c5bf466d..0357a4900 100644 --- a/src/agents/skills/workspace.ts +++ b/src/agents/skills/workspace.ts @@ -52,12 +52,14 @@ function filterSkillEntries( if (skillFilter !== undefined) { const normalized = skillFilter.map((entry) => String(entry).trim()).filter(Boolean); const label = normalized.length > 0 ? normalized.join(", ") : "(none)"; - console.log(`[skills] Applying skill filter: ${label}`); + skillsLogger.debug(`Applying skill filter: ${label}`); filtered = normalized.length > 0 ? filtered.filter((entry) => normalized.includes(entry.skill.name)) : []; - console.log(`[skills] After filter: ${filtered.map((entry) => entry.skill.name).join(", ")}`); + skillsLogger.debug( + `After filter: ${filtered.map((entry) => entry.skill.name).join(", ")}`, + ); } return filtered; } diff --git a/src/hooks/bundled/session-memory/handler.ts b/src/hooks/bundled/session-memory/handler.ts index af3b82c77..932cfb9e3 100644 --- a/src/hooks/bundled/session-memory/handler.ts +++ b/src/hooks/bundled/session-memory/handler.ts @@ -68,8 +68,6 @@ const saveSessionToMemory: HookHandler = async (event) => { } try { - console.log("[session-memory] Hook triggered for /new command"); - const context = event.context || {}; const cfg = context.cfg as OpenClawConfig | undefined; const agentId = resolveAgentIdFromSessionKey(event.sessionKey); @@ -91,10 +89,6 @@ const saveSessionToMemory: HookHandler = async (event) => { const currentSessionId = sessionEntry.sessionId as string; const currentSessionFile = sessionEntry.sessionFile as string; - console.log("[session-memory] Current sessionId:", currentSessionId); - console.log("[session-memory] Current sessionFile:", currentSessionFile); - console.log("[session-memory] cfg present:", !!cfg); - const sessionFile = currentSessionFile || undefined; // Read message count from hook config (default: 15) @@ -110,10 +104,8 @@ const saveSessionToMemory: HookHandler = async (event) => { if (sessionFile) { // Get recent conversation content sessionContent = await getRecentSessionContent(sessionFile, messageCount); - console.log("[session-memory] sessionContent length:", sessionContent?.length || 0); if (sessionContent && cfg) { - console.log("[session-memory] Calling generateSlugViaLLM..."); // Dynamically import the LLM slug generator (avoids module caching issues) // When compiled, handler is at dist/hooks/bundled/session-memory/handler.js // Going up ../.. puts us at dist/hooks/, so just add llm-slug-generator.js @@ -123,7 +115,6 @@ const saveSessionToMemory: HookHandler = async (event) => { // Use LLM to generate a descriptive slug slug = await generateSlugViaLLM({ sessionContent, cfg }); - console.log("[session-memory] Generated slug:", slug); } } @@ -131,14 +122,11 @@ const saveSessionToMemory: HookHandler = async (event) => { if (!slug) { const timeSlug = now.toISOString().split("T")[1]!.split(".")[0]!.replace(/:/g, ""); slug = timeSlug.slice(0, 4); // HHMM - console.log("[session-memory] Using fallback timestamp slug:", slug); } // Create filename with date and slug const filename = `${dateStr}-${slug}.md`; const memoryFilePath = path.join(memoryDir, filename); - console.log("[session-memory] Generated filename:", filename); - console.log("[session-memory] Full path:", memoryFilePath); // Format time as HH:MM:SS UTC const timeStr = now.toISOString().split("T")[1]!.split(".")[0]; @@ -166,11 +154,6 @@ const saveSessionToMemory: HookHandler = async (event) => { // Write to new memory file await fs.writeFile(memoryFilePath, entry, "utf-8"); - console.log("[session-memory] Memory file written successfully"); - - // Log completion (but don't send user-visible confirmation - it's internal housekeeping) - const relPath = memoryFilePath.replace(os.homedir(), "~"); - console.log(`[session-memory] Session context saved to ${relPath}`); } catch (err) { console.error( "[session-memory] Failed to save session memory:",