romtuck/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: handle string thread IDs in queue drain for Slack

Browse Source 
Slack thread timestamps are strings (e.g., '1769015989.090599'), not numbers.
The type check `typeof threadId === 'number'` caused thread IDs to be
dropped when collecting queued messages, resulting in replies going to
the main channel instead of the thread.

Changed to use null checks (`!= null`) which correctly handles both
string and number thread IDs across different providers.
This commit is contained in:
Clawd 2026-01-30 11:04:22 -05:00
parent 09be5d45d5
commit d3b5e28a54
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/auto-reply/reply/queue/drain.ts
View File

@ -40,13 +40,13 @@ export function scheduleFollowupDrain(
const to = item.originatingTo; const to = item.originatingTo;
const accountId = item.originatingAccountId; const accountId = item.originatingAccountId;
const threadId = item.originatingThreadId; const threadId = item.originatingThreadId;
if (!channel && !to && !accountId && typeof threadId !== "number") { if (!channel && !to && !accountId && threadId == null) {
return {}; return {};
} }
if (!isRoutableChannel(channel) || !to) { if (!isRoutableChannel(channel) || !to) {
return { cross: true }; return { cross: true };
} }
const threadKey = typeof threadId === "number" ? String(threadId) : ""; const threadKey = threadId != null ? String(threadId) : "";
return { return {
key: [channel, to, accountId || "", threadKey].join("|"), key: [channel, to, accountId || "", threadKey].join("|"),
}; };
@ -72,7 +72,7 @@ export function scheduleFollowupDrain(
(i) => i.originatingAccountId, (i) => i.originatingAccountId,
)?.originatingAccountId; )?.originatingAccountId;
const originatingThreadId = items.find( const originatingThreadId = items.find(
(i) => typeof i.originatingThreadId === "number", (i) => i.originatingThreadId != null,
)?.originatingThreadId; )?.originatingThreadId;
const prompt = buildCollectPrompt({ const prompt = buildCollectPrompt({