Doctor update: skip restore control-ui when untracked

This commit is contained in:
Artem Khoroshilov 2026-01-30 04:37:44 +02:00
parent 4583f88626
commit eda601c46a
2 changed files with 90 additions and 6 deletions

View File

@ -112,6 +112,9 @@ describe("runGatewayUpdate", () => {
"pnpm install": { stdout: "" }, "pnpm install": { stdout: "" },
"pnpm build": { stdout: "" }, "pnpm build": { stdout: "" },
"pnpm ui:build": { stdout: "" }, "pnpm ui:build": { stdout: "" },
[`git -C ${tempDir} ls-files -- dist/control-ui/`]: {
stdout: "dist/control-ui/index.html\n",
},
[`git -C ${tempDir} checkout -- dist/control-ui/`]: { stdout: "" }, [`git -C ${tempDir} checkout -- dist/control-ui/`]: { stdout: "" },
"pnpm moltbot doctor --non-interactive": { stdout: "" }, "pnpm moltbot doctor --non-interactive": { stdout: "" },
}); });
@ -128,6 +131,39 @@ describe("runGatewayUpdate", () => {
expect(calls).not.toContain(`git -C ${tempDir} checkout --detach ${betaTag}`); expect(calls).not.toContain(`git -C ${tempDir} checkout --detach ${betaTag}`);
}); });
it("skips restoring control-ui when dist/control-ui is not tracked", async () => {
await fs.mkdir(path.join(tempDir, ".git"));
await fs.writeFile(
path.join(tempDir, "package.json"),
JSON.stringify({ name: "moltbot", version: "1.0.0", packageManager: "pnpm@8.0.0" }),
"utf-8",
);
const stableTag = "v1.0.1-1";
const { runner, calls } = createRunner({
[`git -C ${tempDir} rev-parse --show-toplevel`]: { stdout: tempDir },
[`git -C ${tempDir} rev-parse HEAD`]: { stdout: "abc123" },
[`git -C ${tempDir} status --porcelain -- :!dist/control-ui/`]: { stdout: "" },
[`git -C ${tempDir} fetch --all --prune --tags`]: { stdout: "" },
[`git -C ${tempDir} tag --list v* --sort=-v:refname`]: { stdout: `${stableTag}\n` },
[`git -C ${tempDir} checkout --detach ${stableTag}`]: { stdout: "" },
"pnpm install": { stdout: "" },
"pnpm build": { stdout: "" },
"pnpm ui:build": { stdout: "" },
[`git -C ${tempDir} ls-files -- dist/control-ui/`]: { stdout: "" },
"pnpm moltbot doctor --non-interactive": { stdout: "" },
});
const result = await runGatewayUpdate({
cwd: tempDir,
runCommand: async (argv, _options) => runner(argv),
timeoutMs: 5000,
channel: "beta",
});
expect(result.status).toBe("ok");
expect(calls).not.toContain(`git -C ${tempDir} checkout -- dist/control-ui/`);
});
it("skips update when no git root", async () => { it("skips update when no git root", async () => {
await fs.writeFile( await fs.writeFile(
path.join(tempDir, "package.json"), path.join(tempDir, "package.json"),

View File

@ -275,6 +275,41 @@ async function runStep(opts: RunStepOptions): Promise<UpdateStepResult> {
}; };
} }
function skipStep(
opts: Pick<RunStepOptions, "name" | "argv" | "cwd" | "progress" | "stepIndex" | "totalSteps"> & {
stdoutTail?: string | null;
stderrTail?: string | null;
},
): UpdateStepResult {
const { name, argv, cwd, progress, stepIndex, totalSteps, stdoutTail, stderrTail } = opts;
const command = argv.join(" ");
const stepInfo: UpdateStepInfo = {
name,
command,
index: stepIndex,
total: totalSteps,
};
progress?.onStepStart?.(stepInfo);
progress?.onStepComplete?.({
...stepInfo,
durationMs: 0,
exitCode: 0,
stderrTail: stderrTail ?? null,
});
return {
name,
command,
cwd,
durationMs: 0,
exitCode: 0,
stdoutTail: stdoutTail ?? null,
stderrTail: stderrTail ?? null,
};
}
function managerScriptArgs(manager: "pnpm" | "bun" | "npm", script: string, args: string[] = []) { function managerScriptArgs(manager: "pnpm" | "bun" | "npm", script: string, args: string[] = []) {
if (manager === "pnpm") return ["pnpm", script, ...args]; if (manager === "pnpm") return ["pnpm", script, ...args];
if (manager === "bun") return ["bun", "run", script, ...args]; if (manager === "bun") return ["bun", "run", script, ...args];
@ -678,13 +713,26 @@ export async function runGatewayUpdate(opts: UpdateRunnerOptions = {}): Promise<
// Restore dist/control-ui/ to committed state to prevent dirty repo after update // Restore dist/control-ui/ to committed state to prevent dirty repo after update
// (ui:build regenerates assets with new hashes, which would block future updates) // (ui:build regenerates assets with new hashes, which would block future updates)
const restoreUiStep = await runStep( const restoreUiOpts = step(
step( "restore control-ui",
"restore control-ui", ["git", "-C", gitRoot, "checkout", "--", "dist/control-ui/"],
["git", "-C", gitRoot, "checkout", "--", "dist/control-ui/"], gitRoot,
gitRoot,
),
); );
const lsFilesResult = await runCommand(
["git", "-C", gitRoot, "ls-files", "--", "dist/control-ui/"],
{
cwd: gitRoot,
timeoutMs,
},
);
const hasTrackedControlUiFiles =
lsFilesResult.code === 0 && lsFilesResult.stdout.trim().length > 0;
const restoreUiStep = hasTrackedControlUiFiles
? await runStep(restoreUiOpts)
: skipStep({
...restoreUiOpts,
stdoutTail: "Skipped: dist/control-ui/ is not tracked in git.",
});
steps.push(restoreUiStep); steps.push(restoreUiStep);
const doctorStep = await runStep( const doctorStep = await runStep(