From f19971b34a301d22cc23ce1d4fc188681245f4c8 Mon Sep 17 00:00:00 2001 From: Charlie Date: Tue, 27 Jan 2026 04:04:40 +0000 Subject: [PATCH] fix: update comments for clarity in splitMessagesForPreservation function --- src/agents/compaction.test.ts | 4 ++-- src/agents/compaction.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/agents/compaction.test.ts b/src/agents/compaction.test.ts index e04ebcb52..19ad42cc1 100644 --- a/src/agents/compaction.test.ts +++ b/src/agents/compaction.test.ts @@ -220,8 +220,8 @@ describe("splitMessagesForPreservation", () => { const result = splitMessagesForPreservation({ messages, keepLastMessages: 2 }); - // Should preserve both complete pairs (u1+a1, u2+a2), and include the trailing u3 - // because it comes after the preserved pairs + // Should preserve the last 2 complete pairs (u1+a1, u2+a2), plus the trailing incomplete u3 + // because trailing incomplete messages are always included with preserved pairs expect(result.preservedPairs).toBe(2); expect(result.toPreserve.length).toBe(5); // u1, a1, u2, a2, u3 expect(result.toSummarize.length).toBe(0); diff --git a/src/agents/compaction.ts b/src/agents/compaction.ts index 7b047569b..d67b6ff08 100644 --- a/src/agents/compaction.ts +++ b/src/agents/compaction.ts @@ -353,7 +353,7 @@ export function splitMessagesForPreservation(params: { preservedPairs: number; } { const { messages, keepLastMessages } = params; - + if (keepLastMessages <= 0 || messages.length === 0) { return { toSummarize: messages, @@ -390,9 +390,9 @@ export function splitMessagesForPreservation(params: { // If we found a user message, we have a complete pair if (userIndex !== -1) { pairsFound++; - splitIndex = userIndex; // Update split index to start of this pair if (pairsFound >= keepLastMessages) { + splitIndex = userIndex; // Update split index to start of this pair // We've found enough pairs break; }