romtuck/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ringcentral): skip DM policy checks in selfOnly mode

Browse Source 
In selfOnly mode, dmPolicy/allowFrom/groupPolicy settings are now
completely ignored since the owner is always allowed. This simplifies
the logic and avoids confusion.

Updated README to clarify which settings apply in selfOnly mode.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This commit is contained in:
John Lin 2026-01-28 10:20:47 +08:00
parent 857408d78d
commit f77aeeb34c
No known key found for this signature in database
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/ringcentral/README.md
View File

@ -78,6 +78,10 @@ export RINGCENTRAL_JWT="your-jwt-token"
| `allowOtherChats` | boolean | `false` | In selfOnly mode, allow chats other than Personal | | `allowOtherChats` | boolean | `false` | In selfOnly mode, allow chats other than Personal |
| `name` | string | - | Bot display name | | `name` | string | - | Bot display name |
| `textChunkLimit` | number | `4000` | Maximum characters per message chunk | | `textChunkLimit` | number | `4000` | Maximum characters per message chunk |
| `dmPolicy` | string | `"pairing"` | DM policy (only applies when `selfOnly: false`) |
| `groupPolicy` | string | `"allowlist"` | Group policy (only applies when `selfOnly: false`) |
> **Note:** When `selfOnly: true` (default), the `dmPolicy`, `allowFrom`, `groupPolicy`, and related settings are ignored. The bot only responds to the JWT user in their Personal chat.
## Usage ## Usage

8
extensions/ringcentral/src/monitor.ts
View File

@ -330,17 +330,15 @@ async function processMessageWithPipeline(params: {
} }
} }
if (!isGroup) { // DM policy checks - skip entirely in selfOnly mode (owner is always allowed)
if (!isGroup && !selfOnly) {
const dmEnabled = account.config.dm?.enabled !== false; const dmEnabled = account.config.dm?.enabled !== false;
if (dmPolicy === "disabled" || !dmEnabled) { if (dmPolicy === "disabled" || !dmEnabled) {
logVerbose(core, runtime, `Blocked RingCentral DM from ${senderId} (dmPolicy=disabled)`); logVerbose(core, runtime, `Blocked RingCentral DM from ${senderId} (dmPolicy=disabled)`);
return; return;
} }
// In selfOnly mode, always allow the owner if (dmPolicy !== "open") {
const isOwner = selfOnly && ownerId && senderId === ownerId;
if (dmPolicy !== "open" && !isOwner) {
const allowed = senderAllowedForCommands; const allowed = senderAllowedForCommands;
if (!allowed) { if (!allowed) {
if (dmPolicy === "pairing") { if (dmPolicy === "pairing") {