romtuck/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Lint: formatting and unused vars in test

Browse Source
This commit is contained in:
Muhammed Mukhthar CM 2026-01-14 07:10:59 +00:00 committed by Peter Steinberger
parent e41a8c8af1
commit f99e2eaebb
1 changed files with 47 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

89
src/agents/pi-embedded-runner.sanitize-session-history.test.ts
View File

@ -1,104 +1,109 @@
import { describe, it, expect, vi, beforeEach } from 'vitest'; import type { AgentMessage } from "@mariozechner/pi-agent-core";
import { sanitizeSessionHistory } from './pi-embedded-runner/google.js'; import type { SessionManager } from "@mariozechner/pi-coding-agent";
import * as helpers from './pi-embedded-helpers.js'; import { beforeEach, describe, expect, it, vi } from "vitest";
import type { AgentMessage } from '@mariozechner/pi-agent-core'; import * as helpers from "./pi-embedded-helpers.js";
import type { SessionManager } from '@mariozechner/pi-coding-agent'; import { sanitizeSessionHistory } from "./pi-embedded-runner/google.js";
// Mock dependencies // Mock dependencies
vi.mock('./pi-embedded-helpers.js', async () => { vi.mock("./pi-embedded-helpers.js", async () => {
const actual = await vi.importActual('./pi-embedded-helpers.js'); const actual = await vi.importActual("./pi-embedded-helpers.js");
return { return {
...actual, ...actual,
isGoogleModelApi: vi.fn(), isGoogleModelApi: vi.fn(),
downgradeGeminiHistory: vi.fn(), downgradeGeminiHistory: vi.fn(),
sanitizeSessionMessagesImages: vi.fn().mockImplementation(async (msgs) => msgs), sanitizeSessionMessagesImages: vi
.fn()
.mockImplementation(async (msgs) => msgs),
}; };
}); });
// We don't mock session-transcript-repair.js as it is a pure function and complicates mocking. // We don't mock session-transcript-repair.js as it is a pure function and complicates mocking.
// We rely on the real implementation which should pass through our simple messages. // We rely on the real implementation which should pass through our simple messages.
describe('sanitizeSessionHistory', () => { describe("sanitizeSessionHistory", () => {
const mockSessionManager = { const mockSessionManager = {
getEntries: vi.fn().mockReturnValue([]), getEntries: vi.fn().mockReturnValue([]),
appendCustomEntry: vi.fn(), appendCustomEntry: vi.fn(),
} as unknown as SessionManager; } as unknown as SessionManager;
const mockMessages: AgentMessage[] = [ const mockMessages: AgentMessage[] = [{ role: "user", content: "hello" }];
{ role: 'user', content: 'hello' }
];
beforeEach(() => { beforeEach(() => {
vi.resetAllMocks(); vi.resetAllMocks();
vi.mocked(helpers.sanitizeSessionMessagesImages).mockImplementation(async (msgs) => msgs); vi.mocked(helpers.sanitizeSessionMessagesImages).mockImplementation(
async (msgs) => msgs,
);
// Default mock implementation // Default mock implementation
vi.mocked(helpers.downgradeGeminiHistory).mockImplementation((msgs) => { vi.mocked(helpers.downgradeGeminiHistory).mockImplementation((msgs) => {
if (!msgs) return []; if (!msgs) return [];
return [...msgs, { role: 'system', content: 'downgraded' }]; return [...msgs, { role: "system", content: "downgraded" }];
}); });
}); });
it('should downgrade history for Google models if provider is not google-antigravity', async () => { it("should downgrade history for Google models if provider is not google-antigravity", async () => {
vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true); vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true);
const result = await sanitizeSessionHistory({ const result = await sanitizeSessionHistory({
messages: mockMessages, messages: mockMessages,
modelApi: 'google-gemini', modelApi: "google-gemini",
provider: 'google-vertex', provider: "google-vertex",
sessionManager: mockSessionManager, sessionManager: mockSessionManager,
sessionId: 'test-session', sessionId: "test-session",
}); });
expect(helpers.isGoogleModelApi).toHaveBeenCalledWith('google-gemini'); expect(helpers.isGoogleModelApi).toHaveBeenCalledWith("google-gemini");
expect(helpers.downgradeGeminiHistory).toHaveBeenCalled(); expect(helpers.downgradeGeminiHistory).toHaveBeenCalled();
// Check if the result contains the downgraded message // Check if the result contains the downgraded message
expect(result).toContainEqual({ role: 'system', content: 'downgraded' }); expect(result).toContainEqual({ role: "system", content: "downgraded" });
}); });
it('should NOT downgrade history for google-antigravity provider', async () => { it("should NOT downgrade history for google-antigravity provider", async () => {
vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true); vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true);
const result = await sanitizeSessionHistory({ const result = await sanitizeSessionHistory({
messages: mockMessages, messages: mockMessages,
modelApi: 'google-gemini', modelApi: "google-gemini",
provider: 'google-antigravity', provider: "google-antigravity",
sessionManager: mockSessionManager, sessionManager: mockSessionManager,
sessionId: 'test-session', sessionId: "test-session",
}); });
expect(helpers.isGoogleModelApi).toHaveBeenCalledWith('google-gemini'); expect(helpers.isGoogleModelApi).toHaveBeenCalledWith("google-gemini");
expect(helpers.downgradeGeminiHistory).not.toHaveBeenCalled(); expect(helpers.downgradeGeminiHistory).not.toHaveBeenCalled();
// Result should not contain the downgraded message // Result should not contain the downgraded message
expect(result).not.toContainEqual({ role: 'system', content: 'downgraded' }); expect(result).not.toContainEqual({
role: "system",
content: "downgraded",
});
}); });
it('should NOT downgrade history for non-Google models', async () => { it("should NOT downgrade history for non-Google models", async () => {
vi.mocked(helpers.isGoogleModelApi).mockReturnValue(false); vi.mocked(helpers.isGoogleModelApi).mockReturnValue(false);
const _result = await sanitizeSessionHistory({ const _result = await sanitizeSessionHistory({
messages: mockMessages, messages: mockMessages,
modelApi: 'anthropic-messages', modelApi: "anthropic-messages",
provider: 'anthropic', provider: "anthropic",
sessionManager: mockSessionManager, sessionManager: mockSessionManager,
sessionId: 'test-session', sessionId: "test-session",
}); });
expect(helpers.isGoogleModelApi).toHaveBeenCalledWith('anthropic-messages'); expect(helpers.isGoogleModelApi).toHaveBeenCalledWith("anthropic-messages");
expect(helpers.downgradeGeminiHistory).not.toHaveBeenCalled(); expect(helpers.downgradeGeminiHistory).not.toHaveBeenCalled();
}); });
it('should downgrade history if provider is undefined but model is Google', async () => { it("should downgrade history if provider is undefined but model is Google", async () => {
vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true); vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true);
const _result = await sanitizeSessionHistory({ const _result = await sanitizeSessionHistory({
messages: mockMessages, messages: mockMessages,
modelApi: 'google-gemini', modelApi: "google-gemini",
provider: undefined, provider: undefined,
sessionManager: mockSessionManager, sessionManager: mockSessionManager,
sessionId: 'test-session', sessionId: "test-session",
}); });
expect(helpers.isGoogleModelApi).toHaveBeenCalledWith('google-gemini'); expect(helpers.isGoogleModelApi).toHaveBeenCalledWith("google-gemini");
expect(helpers.downgradeGeminiHistory).toHaveBeenCalled(); expect(helpers.downgradeGeminiHistory).toHaveBeenCalled();
}); });
}); });