Commit Graph

5 Commits

Author SHA1 Message Date
Wimmie
e229faf850 fix(sandbox): use absolute /bin/sh path for docker exec
Fixes intermittent 'sh not found' errors in nix2container-based sandbox
images. The OCI runtime PATH resolution can fail sporadically when using
bare 'sh' command. Using absolute path /bin/sh bypasses PATH lookup.

Also adds allowedReadPaths config option for bind mount access:

- Add allowedReadPaths?: string[] to SandboxDockerConfig
- Merge allowedReadPaths arrays from global + agent config (like binds)
- Update resolveSandboxPath/assertSandboxPath to validate paths against
  root OR any allowedPath entry

Example config:
{
  "sandbox": {
    "docker": {
      "binds": ["/host/skills:/workspace/.skills/tameson:ro"],
      "allowedReadPaths": ["/workspace/.skills"]
    }
  }
}
2026-01-29 10:02:45 +00:00
Peter Steinberger
771f23d36b fix(exec): prevent PATH injection in docker sandbox 2026-01-27 04:00:22 +00:00
Peter Steinberger
eaace34233 fix: restore docker binds and PATH in sandbox exec (#873)
Thanks @akonyer.

Co-authored-by: Aaron Konyer <aaronk@gomodular.ca>
2026-01-15 02:58:20 +00:00
Peter Steinberger
c379191f80 chore: migrate to oxlint and oxfmt
Co-authored-by: Christoph Nakazawa <christoph.pojer@gmail.com>
2026-01-14 15:02:19 +00:00
Peter Steinberger
e2f8909982 refactor(agents): split tools + PI subscribe 2026-01-14 05:39:59 +00:00