* refactor: introduce provider plugin registry * refactor: move provider CLI to plugins * docs: add provider plugin implementation notes * refactor: shift provider runtime logic into plugins * refactor: add plugin defaults and summaries * docs: update provider plugin notes * feat(commands): add /commands slash list * Auto-reply: tidy help message * Auto-reply: fix status command lint * Tests: align google shared expectations * Auto-reply: tidy help message * Auto-reply: fix status command lint * refactor: move provider routing into plugins * test: align agent routing expectations * docs: update provider plugin notes * refactor: route replies via provider plugins * docs: note route-reply plugin hooks * refactor: extend provider plugin contract * refactor: derive provider status from plugins * refactor: unify gateway provider control * refactor: use plugin metadata in auto-reply * fix: parenthesize cron target selection * refactor: derive gateway methods from plugins * refactor: generalize provider logout * refactor: route provider logout through plugins * refactor: move WhatsApp web login methods into plugin * refactor: generalize provider log prefixes * refactor: centralize default chat provider * refactor: derive provider lists from registry * refactor: move provider reload noops into plugins * refactor: resolve web login provider via alias * refactor: derive CLI provider options from plugins * refactor: derive prompt provider list from plugins * style: apply biome lint fixes * fix: resolve provider routing edge cases * docs: update provider plugin refactor notes * fix(gateway): harden agent provider routing * refactor: move provider routing into plugins * refactor: move provider CLI to plugins * refactor: derive provider lists from registry * fix: restore slash command parsing * refactor: align provider ids for schema * refactor: unify outbound target resolution * fix: keep outbound labels stable * feat: add msteams to cron surfaces * fix: clean up lint build issues * refactor: localize chat provider alias normalization * refactor: drive gateway provider lists from plugins * docs: update provider plugin notes * style: format message-provider * fix: avoid provider registry init cycles * style: sort message-provider imports * fix: relax provider alias map typing * refactor: move provider routing into plugins * refactor: add plugin pairing/config adapters * refactor: route pairing and provider removal via plugins * refactor: align auto-reply provider typing * test: stabilize telegram media mocks * docs: update provider plugin refactor notes * refactor: pluginize outbound targets * refactor: pluginize provider selection * refactor: generalize text chunk limits * docs: update provider plugin notes * refactor: generalize group session/config * fix: normalize provider id for room detection * fix: avoid provider init in system prompt * style: formatting cleanup * refactor: normalize agent delivery targets * test: update outbound delivery labels * chore: fix lint regressions * refactor: extend provider plugin adapters * refactor: move elevated/block streaming defaults to plugins * refactor: defer outbound send deps to plugins * docs: note plugin-driven streaming/elevated defaults * refactor: centralize webchat provider constant * refactor: add provider setup adapters * refactor: delegate provider add config to plugins * docs: document plugin-driven provider add * refactor: add plugin state/binding metadata * refactor: build agent provider status from plugins * docs: note plugin-driven agent bindings * refactor: centralize internal provider constant usage * fix: normalize WhatsApp targets for groups and E.164 (#631) (thanks @imfing) * refactor: centralize default chat provider * refactor: centralize WhatsApp target normalization * refactor: move provider routing into plugins * refactor: normalize agent delivery targets * chore: fix lint regressions * fix: normalize WhatsApp targets for groups and E.164 (#631) (thanks @imfing) * feat: expand provider plugin adapters * refactor: route auto-reply via provider plugins * fix: align WhatsApp target normalization * fix: normalize WhatsApp targets for groups and E.164 (#631) (thanks @imfing) * refactor: centralize WhatsApp target normalization * feat: add /config chat config updates * docs: add /config get alias * feat(commands): add /commands slash list * refactor: centralize default chat provider * style: apply biome lint fixes * chore: fix lint regressions * fix: clean up whatsapp allowlist typing * style: format config command helpers * refactor: pluginize tool threading context * refactor: normalize session announce targets * docs: note new plugin threading and announce hooks * refactor: pluginize message actions * docs: update provider plugin actions notes * fix: align provider action adapters * refactor: centralize webchat checks * style: format message provider helpers * refactor: move provider onboarding into adapters * docs: note onboarding provider adapters * feat: add msteams onboarding adapter * style: organize onboarding imports * fix: normalize msteams allowFrom types * feat: add plugin text chunk limits * refactor: use plugin chunk limit fallbacks * feat: add provider mention stripping hooks * style: organize provider plugin type imports * refactor: generalize health snapshots * refactor: update macOS health snapshot handling * docs: refresh health snapshot notes * style: format health snapshot updates * refactor: drive security warnings via plugins * docs: note provider security adapter * style: format provider security adapters * refactor: centralize provider account defaults * refactor: type gateway client identity constants * chore: regen gateway protocol swift * fix: degrade health on failed provider probe * refactor: centralize pairing approve hint * docs: add plugin CLI command references * refactor: route auth and tool sends through plugins * docs: expand provider plugin hooks * refactor: document provider docking touchpoints * refactor: normalize internal provider defaults * refactor: streamline outbound delivery wiring * refactor: make provider onboarding plugin-owned * refactor: support provider-owned agent tools * refactor: move telegram draft chunking into telegram module * refactor: infer provider tool sends via extractToolSend * fix: repair plugin onboarding imports * refactor: de-dup outbound target normalization * style: tidy plugin and agent imports * refactor: data-drive provider selection line * fix: satisfy lint after provider plugin rebase * test: deflake gateway-cli coverage * style: format gateway-cli coverage test * refactor(provider-plugins): simplify provider ids * test(pairing-cli): avoid provider-specific ternary * style(macos): swiftformat HealthStore * refactor(sandbox): derive provider tool denylist * fix(sandbox): avoid plugin init in defaults * refactor(provider-plugins): centralize provider aliases * style(test): satisfy biome * refactor(protocol): v3 providers.status maps * refactor(ui): adapt to protocol v3 * refactor(macos): adapt to protocol v3 * test: update providers.status v3 fixtures * refactor(gateway): map provider runtime snapshot * test(gateway): update reload runtime snapshot * refactor(whatsapp): normalize heartbeat provider id * docs(refactor): update provider plugin notes * style: satisfy biome after rebase * fix: describe sandboxed elevated in prompt * feat(gateway): add agent image attachments + live probe * refactor: derive CLI provider options from plugins * fix(gateway): harden agent provider routing * fix(gateway): harden agent provider routing * refactor: align provider ids for schema * fix(protocol): keep agent provider string * fix(gateway): harden agent provider routing * fix(protocol): keep agent provider string * refactor: normalize agent delivery targets * refactor: support provider-owned agent tools * refactor(config): provider-keyed elevated allowFrom * style: satisfy biome * fix(gateway): appease provider narrowing * style: satisfy biome * refactor(reply): move group intro hints into plugin * fix(reply): avoid plugin registry init cycle * refactor(providers): add lightweight provider dock * refactor(gateway): use typed client id in connect * refactor(providers): document docks and avoid init cycles * refactor(providers): make media limit helper generic * fix(providers): break plugin registry import cycles * style: satisfy biome * refactor(status-all): build providers table from plugins * refactor(gateway): delegate web login to provider plugin * refactor(provider): drop web alias * refactor(provider): lazy-load monitors * style: satisfy lint/format * style: format status-all providers table * style: swiftformat gateway discovery model * test: make reload plan plugin-driven * fix: avoid token stringification in status-all * refactor: make provider IDs explicit in status * feat: warn on signal/imessage provider runtime errors * test: cover gateway provider runtime warnings in status * fix: add runtime kind to provider status issues * test: cover health degradation on probe failure * fix: keep routeReply lightweight * style: organize routeReply imports * refactor(web): extract auth-store helpers * refactor(whatsapp): lazy login imports * refactor(outbound): route replies via plugin outbound * docs: update provider plugin notes * style: format provider status issues * fix: make sandbox scope warning wrap-safe * refactor: load outbound adapters from provider plugins * docs: update provider plugin outbound notes * style(macos): fix swiftformat lint * docs: changelog for provider plugins * fix(macos): satisfy swiftformat * fix(macos): open settings via menu action * style: format after rebase * fix(macos): open Settings via menu action --------- Co-authored-by: LK <luke@kyohere.com> Co-authored-by: Luke K (pr-0f3t) <2609441+lc0rp@users.noreply.github.com> Co-authored-by: Xin <xin@imfing.com>
864 lines
25 KiB
TypeScript
864 lines
25 KiB
TypeScript
import fs from "node:fs/promises";
|
|
import path from "node:path";
|
|
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
import { withTempHome as withTempHomeBase } from "../../test/helpers/temp-home.js";
|
|
import type { CliDeps } from "../cli/deps.js";
|
|
import type { ClawdbotConfig } from "../config/config.js";
|
|
import type { CronJob } from "./types.js";
|
|
|
|
vi.mock("../agents/pi-embedded.js", () => ({
|
|
abortEmbeddedPiRun: vi.fn().mockReturnValue(false),
|
|
runEmbeddedPiAgent: vi.fn(),
|
|
resolveEmbeddedSessionLane: (key: string) =>
|
|
`session:${key.trim() || "main"}`,
|
|
}));
|
|
vi.mock("../agents/model-catalog.js", () => ({
|
|
loadModelCatalog: vi.fn(),
|
|
}));
|
|
|
|
import { loadModelCatalog } from "../agents/model-catalog.js";
|
|
import { runEmbeddedPiAgent } from "../agents/pi-embedded.js";
|
|
import { runCronIsolatedAgentTurn } from "./isolated-agent.js";
|
|
|
|
async function withTempHome<T>(fn: (home: string) => Promise<T>): Promise<T> {
|
|
return withTempHomeBase(fn, { prefix: "clawdbot-cron-" });
|
|
}
|
|
|
|
async function writeSessionStore(home: string) {
|
|
const dir = path.join(home, ".clawdbot", "sessions");
|
|
await fs.mkdir(dir, { recursive: true });
|
|
const storePath = path.join(dir, "sessions.json");
|
|
await fs.writeFile(
|
|
storePath,
|
|
JSON.stringify(
|
|
{
|
|
"agent:main:main": {
|
|
sessionId: "main-session",
|
|
updatedAt: Date.now(),
|
|
lastProvider: "webchat",
|
|
lastTo: "",
|
|
},
|
|
},
|
|
null,
|
|
2,
|
|
),
|
|
"utf-8",
|
|
);
|
|
return storePath;
|
|
}
|
|
|
|
function makeCfg(
|
|
home: string,
|
|
storePath: string,
|
|
overrides: Partial<ClawdbotConfig> = {},
|
|
): ClawdbotConfig {
|
|
const base: ClawdbotConfig = {
|
|
agents: {
|
|
defaults: {
|
|
model: "anthropic/claude-opus-4-5",
|
|
workspace: path.join(home, "clawd"),
|
|
},
|
|
},
|
|
session: { store: storePath, mainKey: "main" },
|
|
} as ClawdbotConfig;
|
|
return { ...base, ...overrides };
|
|
}
|
|
|
|
function makeJob(payload: CronJob["payload"]): CronJob {
|
|
const now = Date.now();
|
|
return {
|
|
id: "job-1",
|
|
enabled: true,
|
|
createdAtMs: now,
|
|
updatedAtMs: now,
|
|
schedule: { kind: "every", everyMs: 60_000 },
|
|
sessionTarget: "isolated",
|
|
wakeMode: "now",
|
|
payload,
|
|
state: {},
|
|
isolation: { postToMainPrefix: "Cron" },
|
|
};
|
|
}
|
|
|
|
describe("runCronIsolatedAgentTurn", () => {
|
|
beforeEach(() => {
|
|
vi.mocked(runEmbeddedPiAgent).mockReset();
|
|
vi.mocked(loadModelCatalog).mockResolvedValue([]);
|
|
});
|
|
|
|
it("uses last non-empty agent text as summary", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "first" }, { text: " " }, { text: " last " }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({ kind: "agentTurn", message: "do it", deliver: false }),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(res.summary).toBe("last");
|
|
});
|
|
});
|
|
|
|
it("uses model override when provided", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "ok" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
model: "openai/gpt-4.1-mini",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
const call = vi.mocked(runEmbeddedPiAgent).mock.calls[0]?.[0] as {
|
|
provider?: string;
|
|
model?: string;
|
|
};
|
|
expect(call?.provider).toBe("openai");
|
|
expect(call?.model).toBe("gpt-4.1-mini");
|
|
});
|
|
});
|
|
|
|
it("uses hooks.gmail.model for Gmail hook sessions", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "ok" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath, {
|
|
hooks: {
|
|
gmail: {
|
|
model: "openrouter/meta-llama/llama-3.3-70b:free",
|
|
},
|
|
},
|
|
}),
|
|
deps,
|
|
job: makeJob({ kind: "agentTurn", message: "do it", deliver: false }),
|
|
message: "do it",
|
|
sessionKey: "hook:gmail:msg-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
const call = vi.mocked(runEmbeddedPiAgent).mock.calls[0]?.[0] as {
|
|
provider?: string;
|
|
model?: string;
|
|
};
|
|
expect(call?.provider).toBe("openrouter");
|
|
expect(call?.model).toBe("meta-llama/llama-3.3-70b:free");
|
|
});
|
|
});
|
|
|
|
it("ignores hooks.gmail.model when not in the allowlist", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "ok" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
vi.mocked(loadModelCatalog).mockResolvedValueOnce([
|
|
{
|
|
id: "claude-opus-4-5",
|
|
name: "Opus 4.5",
|
|
provider: "anthropic",
|
|
},
|
|
]);
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath, {
|
|
agents: {
|
|
defaults: {
|
|
model: "anthropic/claude-opus-4-5",
|
|
models: {
|
|
"anthropic/claude-opus-4-5": { alias: "Opus" },
|
|
},
|
|
},
|
|
},
|
|
hooks: {
|
|
gmail: {
|
|
model: "openrouter/meta-llama/llama-3.3-70b:free",
|
|
},
|
|
},
|
|
}),
|
|
deps,
|
|
job: makeJob({ kind: "agentTurn", message: "do it", deliver: false }),
|
|
message: "do it",
|
|
sessionKey: "hook:gmail:msg-2",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
const call = vi.mocked(runEmbeddedPiAgent).mock.calls[0]?.[0] as {
|
|
provider?: string;
|
|
model?: string;
|
|
};
|
|
expect(call?.provider).toBe("anthropic");
|
|
expect(call?.model).toBe("claude-opus-4-5");
|
|
});
|
|
});
|
|
|
|
it("rejects invalid model override", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockReset();
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
model: "openai/",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("error");
|
|
expect(res.error).toMatch("invalid model");
|
|
expect(vi.mocked(runEmbeddedPiAgent)).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it("defaults thinking to low for reasoning-capable models", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "done" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
vi.mocked(loadModelCatalog).mockResolvedValueOnce([
|
|
{
|
|
id: "claude-opus-4-5",
|
|
name: "Opus 4.5",
|
|
provider: "anthropic",
|
|
reasoning: true,
|
|
},
|
|
]);
|
|
|
|
await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({ kind: "agentTurn", message: "do it", deliver: false }),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
const callArgs = vi.mocked(runEmbeddedPiAgent).mock.calls.at(-1)?.[0];
|
|
expect(callArgs?.thinkLevel).toBe("low");
|
|
});
|
|
});
|
|
|
|
it("truncates long summaries", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
const long = "a".repeat(2001);
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: long }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({ kind: "agentTurn", message: "do it", deliver: false }),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(String(res.summary ?? "")).toMatch(/…$/);
|
|
});
|
|
});
|
|
|
|
it("fails delivery without a WhatsApp recipient when bestEffortDeliver=false", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "hello" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "whatsapp",
|
|
bestEffortDeliver: false,
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("error");
|
|
expect(res.summary).toBe("hello");
|
|
expect(String(res.error ?? "")).toMatch(/requires a recipient/i);
|
|
expect(deps.sendMessageWhatsApp).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it("skips delivery without a WhatsApp recipient when bestEffortDeliver=true", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "hello" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "whatsapp",
|
|
bestEffortDeliver: true,
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("skipped");
|
|
expect(String(res.summary ?? "")).toMatch(/delivery skipped/i);
|
|
expect(deps.sendMessageWhatsApp).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it("delivers telegram via provider send", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn().mockResolvedValue({
|
|
messageId: "t1",
|
|
chatId: "123",
|
|
}),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "hello from cron" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const prevTelegramToken = process.env.TELEGRAM_BOT_TOKEN;
|
|
process.env.TELEGRAM_BOT_TOKEN = "";
|
|
try {
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath, { telegram: { botToken: "t-1" } }),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "telegram",
|
|
to: "123",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(deps.sendMessageTelegram).toHaveBeenCalledWith(
|
|
"123",
|
|
"hello from cron",
|
|
expect.objectContaining({ verbose: false }),
|
|
);
|
|
} finally {
|
|
if (prevTelegramToken === undefined) {
|
|
delete process.env.TELEGRAM_BOT_TOKEN;
|
|
} else {
|
|
process.env.TELEGRAM_BOT_TOKEN = prevTelegramToken;
|
|
}
|
|
}
|
|
});
|
|
});
|
|
|
|
it("delivers telegram topic targets via provider send", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn().mockResolvedValue({
|
|
messageId: "t1",
|
|
chatId: "-1001234567890",
|
|
}),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "hello from cron" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "telegram",
|
|
to: "telegram:group:-1001234567890:topic:321",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(deps.sendMessageTelegram).toHaveBeenCalledWith(
|
|
"telegram:group:-1001234567890:topic:321",
|
|
"hello from cron",
|
|
expect.objectContaining({ verbose: false }),
|
|
);
|
|
});
|
|
});
|
|
|
|
it("delivers telegram shorthand topic suffixes via provider send", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn().mockResolvedValue({
|
|
messageId: "t1",
|
|
chatId: "-1001234567890",
|
|
}),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "hello from cron" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "telegram",
|
|
to: "-1001234567890:321",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(deps.sendMessageTelegram).toHaveBeenCalledWith(
|
|
"-1001234567890:321",
|
|
"hello from cron",
|
|
expect.objectContaining({ verbose: false }),
|
|
);
|
|
});
|
|
});
|
|
|
|
it("delivers via discord when configured", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn().mockResolvedValue({
|
|
messageId: "d1",
|
|
channelId: "chan",
|
|
}),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "hello from cron" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "discord",
|
|
to: "channel:1122",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(deps.sendMessageDiscord).toHaveBeenCalledWith(
|
|
"channel:1122",
|
|
"hello from cron",
|
|
expect.objectContaining({ verbose: false }),
|
|
);
|
|
});
|
|
});
|
|
|
|
it("skips delivery when response is exactly HEARTBEAT_OK", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn().mockResolvedValue({
|
|
messageId: "t1",
|
|
chatId: "123",
|
|
}),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "HEARTBEAT_OK" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "telegram",
|
|
to: "123",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
// Job still succeeds, but no delivery happens.
|
|
expect(res.status).toBe("ok");
|
|
expect(res.summary).toBe("HEARTBEAT_OK");
|
|
expect(deps.sendMessageTelegram).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it("skips delivery when response has HEARTBEAT_OK with short padding", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn().mockResolvedValue({
|
|
messageId: "w1",
|
|
chatId: "+1234",
|
|
}),
|
|
sendMessageTelegram: vi.fn(),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
// Short junk around HEARTBEAT_OK (<=30 chars) should still skip delivery.
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "HEARTBEAT_OK 🦞" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath, { whatsapp: { allowFrom: ["+1234"] } }),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "whatsapp",
|
|
to: "+1234",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(deps.sendMessageWhatsApp).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it("delivers when response has HEARTBEAT_OK but also substantial content", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn().mockResolvedValue({
|
|
messageId: "t1",
|
|
chatId: "123",
|
|
}),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
// Long content after HEARTBEAT_OK should still be delivered.
|
|
const longContent = `Important alert: ${"a".repeat(50)}`;
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: `HEARTBEAT_OK ${longContent}` }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "telegram",
|
|
to: "123",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(deps.sendMessageTelegram).toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it("delivers when response has HEARTBEAT_OK but includes media", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn().mockResolvedValue({
|
|
messageId: "t1",
|
|
chatId: "123",
|
|
}),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
// Media should still be delivered even if text is just HEARTBEAT_OK.
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [
|
|
{ text: "HEARTBEAT_OK", mediaUrl: "https://example.com/img.png" },
|
|
],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg: makeCfg(home, storePath),
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "telegram",
|
|
to: "123",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(deps.sendMessageTelegram).toHaveBeenCalledWith(
|
|
"123",
|
|
"HEARTBEAT_OK",
|
|
expect.objectContaining({ mediaUrl: "https://example.com/img.png" }),
|
|
);
|
|
});
|
|
});
|
|
|
|
it("delivers when heartbeat ack padding exceeds configured limit", async () => {
|
|
await withTempHome(async (home) => {
|
|
const storePath = await writeSessionStore(home);
|
|
const deps: CliDeps = {
|
|
sendMessageWhatsApp: vi.fn(),
|
|
sendMessageTelegram: vi.fn().mockResolvedValue({
|
|
messageId: "t1",
|
|
chatId: "123",
|
|
}),
|
|
sendMessageDiscord: vi.fn(),
|
|
sendMessageSignal: vi.fn(),
|
|
sendMessageIMessage: vi.fn(),
|
|
};
|
|
vi.mocked(runEmbeddedPiAgent).mockResolvedValue({
|
|
payloads: [{ text: "HEARTBEAT_OK 🦞" }],
|
|
meta: {
|
|
durationMs: 5,
|
|
agentMeta: { sessionId: "s", provider: "p", model: "m" },
|
|
},
|
|
});
|
|
|
|
const cfg = makeCfg(home, storePath);
|
|
cfg.agents = {
|
|
...cfg.agents,
|
|
defaults: {
|
|
...cfg.agents?.defaults,
|
|
heartbeat: { ackMaxChars: 0 },
|
|
},
|
|
};
|
|
|
|
const res = await runCronIsolatedAgentTurn({
|
|
cfg,
|
|
deps,
|
|
job: makeJob({
|
|
kind: "agentTurn",
|
|
message: "do it",
|
|
deliver: true,
|
|
provider: "telegram",
|
|
to: "123",
|
|
}),
|
|
message: "do it",
|
|
sessionKey: "cron:job-1",
|
|
lane: "cron",
|
|
});
|
|
|
|
expect(res.status).toBe("ok");
|
|
expect(deps.sendMessageTelegram).toHaveBeenCalled();
|
|
});
|
|
});
|
|
});
|