Fixes issue where unauthorized messages from +212652169245 (5elements spa) triggered Bad MAC errors and silently killed the event emitter, preventing all future message processing. Changes: 1. Early allowFrom filtering in inbound.ts - blocks unauthorized senders before they trigger encryption errors 2. Message timeout watchdog - auto-restarts connection if no messages received for 10 minutes 3. Health monitoring in heartbeat - warns if >30 min without messages 4. Mock loadConfig in tests to handle new dependency Root cause: Event emitter stopped firing after Bad MAC errors from decryption attempts on messages from unauthorized senders. Connection stayed alive but all subsequent messages.upsert events silently failed.
228 lines
6.3 KiB
TypeScript
228 lines
6.3 KiB
TypeScript
import { vi } from "vitest";
|
|
|
|
vi.mock("../media/store.js", () => ({
|
|
saveMediaBuffer: vi.fn().mockResolvedValue({
|
|
id: "mid",
|
|
path: "/tmp/mid",
|
|
size: 1,
|
|
contentType: "image/jpeg",
|
|
}),
|
|
}));
|
|
|
|
vi.mock("../config/config.js", () => ({
|
|
loadConfig: vi.fn().mockReturnValue({
|
|
inbound: {
|
|
allowFrom: ["*"], // Allow all in tests
|
|
},
|
|
}),
|
|
}));
|
|
|
|
vi.mock("./session.js", () => {
|
|
const { EventEmitter } = require("node:events");
|
|
const ev = new EventEmitter();
|
|
const sock = {
|
|
ev,
|
|
ws: { close: vi.fn() },
|
|
sendPresenceUpdate: vi.fn().mockResolvedValue(undefined),
|
|
sendMessage: vi.fn().mockResolvedValue(undefined),
|
|
readMessages: vi.fn().mockResolvedValue(undefined),
|
|
updateMediaMessage: vi.fn(),
|
|
logger: {},
|
|
user: { id: "123@s.whatsapp.net" },
|
|
};
|
|
return {
|
|
createWaSocket: vi.fn().mockResolvedValue(sock),
|
|
waitForWaConnection: vi.fn().mockResolvedValue(undefined),
|
|
getStatusCode: vi.fn(() => 500),
|
|
};
|
|
});
|
|
|
|
const { createWaSocket } = await import("./session.js");
|
|
const _getSock = () =>
|
|
(createWaSocket as unknown as () => Promise<ReturnType<typeof mockSock>>)();
|
|
|
|
import crypto from "node:crypto";
|
|
import fsSync from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
import { afterEach, beforeEach, describe, expect, it } from "vitest";
|
|
|
|
import { resetLogger, setLoggerOverride } from "../logging.js";
|
|
import { monitorWebInbox } from "./inbound.js";
|
|
|
|
describe("web monitor inbox", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
afterEach(() => {
|
|
resetLogger();
|
|
setLoggerOverride(null);
|
|
vi.useRealTimers();
|
|
});
|
|
|
|
it("streams inbound messages", async () => {
|
|
const onMessage = vi.fn(async (msg) => {
|
|
await msg.sendComposing();
|
|
await msg.reply("pong");
|
|
});
|
|
|
|
const listener = await monitorWebInbox({ verbose: false, onMessage });
|
|
const sock = await createWaSocket();
|
|
expect(sock.sendPresenceUpdate).toHaveBeenCalledWith("available");
|
|
const upsert = {
|
|
type: "notify",
|
|
messages: [
|
|
{
|
|
key: { id: "abc", fromMe: false, remoteJid: "999@s.whatsapp.net" },
|
|
message: { conversation: "ping" },
|
|
messageTimestamp: 1_700_000_000,
|
|
pushName: "Tester",
|
|
},
|
|
],
|
|
};
|
|
|
|
sock.ev.emit("messages.upsert", upsert);
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
|
|
expect(onMessage).toHaveBeenCalledWith(
|
|
expect.objectContaining({ body: "ping", from: "+999", to: "+123" }),
|
|
);
|
|
expect(sock.readMessages).toHaveBeenCalledWith([
|
|
{
|
|
remoteJid: "999@s.whatsapp.net",
|
|
id: "abc",
|
|
participant: undefined,
|
|
fromMe: false,
|
|
},
|
|
]);
|
|
expect(sock.sendPresenceUpdate).toHaveBeenCalledWith("available");
|
|
expect(sock.sendPresenceUpdate).toHaveBeenCalledWith(
|
|
"composing",
|
|
"999@s.whatsapp.net",
|
|
);
|
|
expect(sock.sendMessage).toHaveBeenCalledWith("999@s.whatsapp.net", {
|
|
text: "pong",
|
|
});
|
|
|
|
await listener.close();
|
|
});
|
|
|
|
it("captures media path for image messages", async () => {
|
|
const onMessage = vi.fn();
|
|
const listener = await monitorWebInbox({ verbose: false, onMessage });
|
|
const sock = await createWaSocket();
|
|
const upsert = {
|
|
type: "notify",
|
|
messages: [
|
|
{
|
|
key: { id: "med1", fromMe: false, remoteJid: "888@s.whatsapp.net" },
|
|
message: { imageMessage: { mimetype: "image/jpeg" } },
|
|
messageTimestamp: 1_700_000_100,
|
|
},
|
|
],
|
|
};
|
|
|
|
sock.ev.emit("messages.upsert", upsert);
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
|
|
expect(onMessage).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
body: "<media:image>",
|
|
}),
|
|
);
|
|
expect(sock.readMessages).toHaveBeenCalledWith([
|
|
{
|
|
remoteJid: "888@s.whatsapp.net",
|
|
id: "med1",
|
|
participant: undefined,
|
|
fromMe: false,
|
|
},
|
|
]);
|
|
expect(sock.sendPresenceUpdate).toHaveBeenCalledWith("available");
|
|
await listener.close();
|
|
});
|
|
|
|
it("resolves onClose when the socket closes", async () => {
|
|
const listener = await monitorWebInbox({
|
|
verbose: false,
|
|
onMessage: vi.fn(),
|
|
});
|
|
const sock = await createWaSocket();
|
|
const reasonPromise = listener.onClose;
|
|
sock.ev.emit("connection.update", {
|
|
connection: "close",
|
|
lastDisconnect: { error: { output: { statusCode: 500 } } },
|
|
});
|
|
await expect(reasonPromise).resolves.toEqual(
|
|
expect.objectContaining({ status: 500, isLoggedOut: false }),
|
|
);
|
|
await listener.close();
|
|
});
|
|
|
|
it("logs inbound bodies to file", async () => {
|
|
const logPath = path.join(
|
|
os.tmpdir(),
|
|
`warelay-log-test-${crypto.randomUUID()}.log`,
|
|
);
|
|
setLoggerOverride({ level: "trace", file: logPath });
|
|
|
|
const onMessage = vi.fn();
|
|
const listener = await monitorWebInbox({ verbose: false, onMessage });
|
|
const sock = await createWaSocket();
|
|
const upsert = {
|
|
type: "notify",
|
|
messages: [
|
|
{
|
|
key: { id: "abc", fromMe: false, remoteJid: "999@s.whatsapp.net" },
|
|
message: { conversation: "ping" },
|
|
messageTimestamp: 1_700_000_000,
|
|
pushName: "Tester",
|
|
},
|
|
],
|
|
};
|
|
|
|
sock.ev.emit("messages.upsert", upsert);
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
|
|
const content = fsSync.readFileSync(logPath, "utf-8");
|
|
expect(content).toContain('"module":"web-inbound"');
|
|
expect(content).toContain('"body":"ping"');
|
|
await listener.close();
|
|
});
|
|
|
|
it("includes participant when marking group messages read", async () => {
|
|
const onMessage = vi.fn();
|
|
const listener = await monitorWebInbox({ verbose: false, onMessage });
|
|
const sock = await createWaSocket();
|
|
const upsert = {
|
|
type: "notify",
|
|
messages: [
|
|
{
|
|
key: {
|
|
id: "grp1",
|
|
fromMe: false,
|
|
remoteJid: "12345-67890@g.us",
|
|
participant: "111@s.whatsapp.net",
|
|
},
|
|
message: { conversation: "group ping" },
|
|
},
|
|
],
|
|
};
|
|
|
|
sock.ev.emit("messages.upsert", upsert);
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
|
|
expect(sock.readMessages).toHaveBeenCalledWith([
|
|
{
|
|
remoteJid: "12345-67890@g.us",
|
|
id: "grp1",
|
|
participant: "111@s.whatsapp.net",
|
|
fromMe: false,
|
|
},
|
|
]);
|
|
await listener.close();
|
|
});
|
|
});
|